Skip to content

Conversation

spaze
Copy link
Contributor

@spaze spaze commented Feb 8, 2023

  • Fix errors reported by PHPStan (nulls instead of strings & ints in a test file)
  • Run PHPStan in CI
  • ... and on PRs

I'd also recommend protecting the default branch in repo settings and making the tests required before a PR can be merged.

@antonioribeiro
Copy link
Owner

Hey @spaze, thanks for this PR. We just need you to, please, sign your commits so we can approve it:

https://docs.github.com/articles/about-gpg/
https://dev.to/zahrakhadijha/git-fixing-unsigned-gpg-commits-phn

@spaze
Copy link
Contributor Author

spaze commented Feb 27, 2023

Hey, sorry missed the check. All commits now signed, thanks!

@antonioribeiro antonioribeiro merged commit d2afe42 into antonioribeiro:8.x Mar 1, 2023
@spaze spaze deleted the spaze/phpstan-ci branch March 1, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants