-
-
Notifications
You must be signed in to change notification settings - Fork 573
chore(deps): Use latest available Python 3.12 base image #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Dockerfile was updated to change the base image used for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Python base Docker image to use the latest available Python 3.12 version with Alpine Linux to ensure the latest security updates are included. The change removes the specific patch version pinning to allow automatic updates to the newest 3.12.x release.
- Removes specific Python patch version (3.12.0) and Alpine version (3.17) pinning
- Updates to use generic
python:3.12-alpine
tag for automatic security updates - Updates the SHA256 hash to match the new image reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
1-1
: Ensure Renovate continues to bump the digest after moving to the floating3.12-alpine
tagThe intent is to receive security updates automatically, yet the presence of the SHA digest still locks the image to a single build. Confirm that your Renovate configuration watches and updates the digest for floating tags; if not, you will remain on this exact layer and miss new patches.
Options if Renovate cannot track digests for floating tags:
• remove the digest and rely on the mutable tag, or
• keep a fully versioned tag (3.12.x-alpineX
) that Renovate can bump.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: 🧪 Tests / pytest@🐍3.12@macos-13
- GitHub Check: 🧪 Tests / pytest@🐍3.11@macos-13
- GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-14
- GitHub Check: 🧪 Tests / pytest@🐍3.13@macos-13
- GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-13
- GitHub Check: pre-commit
This PR is included in version 1.100.0 🎉 |
Description of your changes
In #915 I find out that current base docker image wasn't updated for 6 months, as Renovate updates SHA, but for some reason doesn't update image tag version (not supported?).
To fix that, I loose tag, to get latest security updates for docker image