Skip to content

Conversation

MaxymVlasov
Copy link
Collaborator

Description of your changes

In #915 I find out that current base docker image wasn't updated for 6 months, as Renovate updates SHA, but for some reason doesn't update image tag version (not supported?).

To fix that, I loose tag, to get latest security updates for docker image

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 17:25
Copy link

coderabbitai bot commented Aug 7, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated base image and package versions in the build configuration for improved compatibility and security.
    • Upgraded gcc and openssh-client to newer versions.
    • Adjusted test configurations to match updated package versions.

Walkthrough

The Dockerfile was updated to change the base image used for the python_base build stage. The reference now points to a different Python 3.12 Alpine image identified by a new sha256 digest. Additionally, the versions of gcc and openssh-client packages installed via apk were upgraded. The container structure test configuration and the checkov.sh installation script were also updated to reflect these new version numbers.

Changes

Cohort / File(s) Change Summary
Docker base image and package upgrades
Dockerfile
Updated the base image reference for the python_base stage to a new Python 3.12 Alpine image with a different sha256 digest. Upgraded gcc from ~12 to ~14 and openssh-client from ~9 to ~10 in the final image.
Container structure test version updates
.github/.container-structure-test-config.yaml
Updated expected version patterns for gcc and ssh commands to match upgraded package versions (gcc 14, OpenSSH 10).
Installation script package version update
tools/install/checkov.sh
Changed the gcc version constraint from ~12 to ~14 in the Alpine package installation command.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

area/docker

Suggested reviewers

  • antonbabenko
  • yermulnik

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ad8dd2 and 0d6d9b7.

📒 Files selected for processing (3)
  • .github/.container-structure-test-config.yaml (2 hunks)
  • Dockerfile (2 hunks)
  • tools/install/checkov.sh (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • .github/.container-structure-test-config.yaml
  • tools/install/checkov.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@macos-14
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-14
  • GitHub Check: 🧹 Linters / pre-commit@🐍3.13@ubuntu-latest
  • GitHub Check: Ubuntu x64
  • GitHub Check: Ubuntu ARM
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docker_deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Python base Docker image to use the latest available Python 3.12 version with Alpine Linux to ensure the latest security updates are included. The change removes the specific patch version pinning to allow automatic updates to the newest 3.12.x release.

  • Removes specific Python patch version (3.12.0) and Alpine version (3.17) pinning
  • Updates to use generic python:3.12-alpine tag for automatic security updates
  • Updates the SHA256 hash to match the new image reference

@MaxymVlasov MaxymVlasov marked this pull request as draft August 7, 2025 17:26
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Dockerfile (1)

1-1: Ensure Renovate continues to bump the digest after moving to the floating 3.12-alpine tag

The intent is to receive security updates automatically, yet the presence of the SHA digest still locks the image to a single build. Confirm that your Renovate configuration watches and updates the digest for floating tags; if not, you will remain on this exact layer and miss new patches.

Options if Renovate cannot track digests for floating tags:
• remove the digest and rely on the mutable tag, or
• keep a fully versioned tag (3.12.x-alpineX) that Renovate can bump.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4b0a46 and 03967e2.

📒 Files selected for processing (1)
  • Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@macos-13
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@macos-13
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-14
  • GitHub Check: 🧪 Tests / pytest@🐍3.13@macos-13
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-13
  • GitHub Check: pre-commit

@MaxymVlasov MaxymVlasov marked this pull request as ready for review August 7, 2025 17:43
@MaxymVlasov MaxymVlasov enabled auto-merge (squash) August 8, 2025 00:50
@MaxymVlasov MaxymVlasov merged commit a134d16 into master Aug 8, 2025
47 checks passed
@MaxymVlasov MaxymVlasov deleted the docker_deps branch August 8, 2025 00:54
@antonbabenko
Copy link
Owner

This PR is included in version 1.100.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants