-
-
Notifications
You must be signed in to change notification settings - Fork 564
chore: Add Open Source Security Foundation best practices badge #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughSummary by CodeRabbit
Summary by CodeRabbit
WalkthroughThe pull request introduces an OpenSSF Best Practices badge to the Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
33-33
: Nit: Validate the badge image URL
The reference URLhttps://www.bestpractices.dev/projects/9963/badge
should return an SVG. Some badge endpoints require an explicit.svg
suffix. Confirm via browser orcurl
that the current path serves the image, or adjust (e.g./badge.svg
) if necessary.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(2 hunks)
🔇 Additional comments (1)
README.md (1)
9-9
: Confirm badge renders and links correctly
Please preview the updated README to ensure that theOpenSSF Best Practices Badge
:
- Loads the SVG image via the
[OpenSSF Best Practices Badge]
reference.- Links to the correct page at
https://www.bestpractices.dev/projects/9963
.
Previously I filled mostly all question, except last section about SAST and Fuzzing.
SAST will be covered by CodeQL and zizmor later.
We can wait with merge of this badge till it will not become "greener"
Relates #712