Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add hadolint check for Dockerfiles #322

Merged
merged 5 commits into from
Jan 11, 2022
Merged

chore: Add hadolint check for Dockerfiles #322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
430f447
Add hadolint check for Dockerfiles
MaxymVlasov Jan 11, 2022
128ae6e
Fix Dockerfile issues
MaxymVlasov Jan 11, 2022
5c6a15d
Make configs up-to-date
MaxymVlasov Jan 11, 2022
7e34de0
Fix shellcheck issue
MaxymVlasov Jan 11, 2022
fa08179
Apply suggestions from code review
MaxymVlasov Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make configs up-to-date
  • Loading branch information
@MaxymVlasov
MaxymVlasov committed Jan 11, 2022
commit 5c6a15d76769a32d3b9bfa88b7405c859e297783
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ sudo apt install -y datamash

```bash
# Build `pre-commit` image
MaxymVlasov marked this conversation as resolved.
Show resolved Hide resolved
docker build -t pre-commit --build-arg INSTALL_ALL=true .
docker build -t pre-commit-terraform --build-arg INSTALL_ALL=true .
MaxymVlasov marked this conversation as resolved.
Show resolved Hide resolved
# Build test image
docker build -t pre-commit-tests tests/
# Run
Expand Down
2 changes: 1 addition & 1 deletion tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM pre-commit:latest
FROM pre-commit-terraform:latest

RUN apt update && \
apt install -y \
Expand Down