Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(game-victory): change helper to service #572

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

antoinezanardi
Copy link
Owner

@antoinezanardi antoinezanardi commented Oct 15, 2023

Closes #541

@antoinezanardi antoinezanardi added the 🔩 refactor Code change that neither fixes a bug nor adds a feature label Oct 15, 2023
@antoinezanardi antoinezanardi self-assigned this Oct 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@antoinezanardi antoinezanardi merged commit 8ee0a57 into develop Oct 15, 2023
15 checks passed
@antoinezanardi antoinezanardi deleted the refactor/game-victory-helper-into-service branch October 15, 2023 10:04
antoinezanardi pushed a commit that referenced this pull request Oct 28, 2023
## [1.21.0](v1.20.0...v1.21.0) (2023-10-28)

### 🚀 Features

* **game-play:** can be skipped field for current game play ([#583](#583)) ([a5908ef](a5908ef))
* **game-play:** targets boundaries for current game play ([#613](#613)) ([2b7b72b](2b7b72b))

### 🐛 Bug Fixes

* **ci:** set workflow github name when merging main into develop ([#573](#573)) ([ff7d103](ff7d103))

### 🔩 Refactor

* **game-victory:** change helper to service ([#572](#572)) ([8ee0a57](8ee0a57)), closes [#541](#541)

### ✅ Tests

* **acceptance:** acceptance tests for api exceptions ([#593](#593)) ([d955b61](d955b61))
* **database:** parallelize e2e tests with multiple databases ([#582](#582)) ([d95b16a](d95b16a))
* **game:** acceptance tests for game creation ([#606](#606)) ([f66c718](f66c718)), closes [#602](#602)
* **rusty-sword-knight:** acceptance tests for rusty sword knight ([#605](#605)) ([92ea4b2](92ea4b2)), closes [#598](#598)

### 🔁 CI

* **stryker:** dedicated config for stryker in ci ([#581](#581)) ([307b9de](307b9de))

### 🧹 Chore

* **deps:** bump @cucumber/cucumber from 10.0.0 to 10.0.1 ([#596](#596)) ([3a5c324](3a5c324))
* **deps:** bump @faker-js/faker from 8.1.0 to 8.2.0 ([#580](#580)) ([82d1f93](82d1f93))
* **deps:** bump lint-staged from 14.0.1 to 15.0.1 ([#578](#578)) ([a46d4ef](a46d4ef))
* **deps:** bump lint-staged from 15.0.1 to 15.0.2 ([#592](#592)) ([63d30fb](63d30fb))
* **deps:** bump mongoose from 7.6.1 to 7.6.2 ([#579](#579)) ([cb0578e](cb0578e))
* **deps:** bump mongoose from 7.6.2 to 7.6.3 ([#587](#587)) ([d829dc8](d829dc8)), closes [#13984](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13984) [#13951](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13951) [#13983](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13983) [#13962](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13962) [#13981](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13981) [#13944](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13944) [#13976](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13976) [#13984](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13984) [#13951](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13951) [#13983](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13983) [#13962](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13962) [#13981](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13981) [#13944](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13944) [#13976](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13976) [#13984](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13984) [#13983](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13983) [#13981](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13981) [#13979](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13979) [#13976](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/13976)
* **deps:** bump the commitlint group with 1 update ([#610](#610)) ([7f36c49](7f36c49))
* **deps:** bump the commitlint group with 2 updates ([#576](#576)) ([f824b74](f824b74))
* **deps:** bump the commitlint group with 2 updates ([#594](#594)) ([8a6e541](8a6e541))
* **deps:** bump the commitlint group with 2 updates ([#608](#608)) ([a139487](a139487))
* **deps:** bump the eslint group with 1 update ([#611](#611)) ([7a736bf](7a736bf))
* **deps:** bump the eslint group with 3 updates ([#597](#597)) ([78de281](78de281))
* **deps:** bump the nest group with 2 updates ([#600](#600)) ([00b7208](00b7208))
* **deps:** bump the stryker group with 3 updates ([#577](#577)) ([3c61640](3c61640))
* **deps:** bump the types group with 1 update ([#607](#607)) ([366715a](366715a))
* **deps:** bump the types group with 2 updates ([#575](#575)) ([0af2c04](0af2c04))
* **deps:** bump the types group with 2 updates ([#584](#584)) ([830ac85](830ac85)), closes [#7722](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7722) [#7724](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7724) [#7717](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7717) [#7718](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7718) [#7117](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7117) [#7722](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7722) [#7724](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7724) [#7717](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7717) [#7718](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7718) [#7117](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7117) [#7117](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7117) [#7718](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7718) [#7715](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7715) [#7669](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7669) [#7722](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7722) [#7724](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7724) [#7717](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7717) [#7718](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7718) [#7117](https://github.com/antoinezanardi/werewolves-assistant-api-next/issues/7117)
* **deps:** bump the types group with 3 updates ([#589](#589)) ([665ac6e](665ac6e))
* **deps:** bump the types group with 3 updates ([#601](#601)) ([afb8644](afb8644))
* **deps:** bump the types group with 4 updates ([#588](#588)) ([6aec9c7](6aec9c7))
* **deps:** bump type-fest from 4.4.0 to 4.5.0 ([#590](#590)) ([646c5f1](646c5f1))
* **deps:** bump type-fest from 4.5.0 to 4.6.0 ([#609](#609)) ([d0a2ef9](d0a2ef9))
* **github-actions:** bump actions/setup-node from 3 to 4 ([#599](#599)) ([1e9b523](1e9b523))
* **node:** bump node to v21 ([#585](#585)) ([158a927](158a927))
* **package-json:** add some properties like "type" ([#604](#604)) ([ad7738f](ad7738f))
@antoinezanardi
Copy link
Owner Author

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 refactor Code change that neither fixes a bug nor adds a feature released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant