Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prefer-numeric-literals ESLint rule #431

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add prefer-numeric-literals ESLint rule

This PR adds the prefer-numeric-literals ESLint rule set to "error" as requested in Slack channel #shortest.

Changes

  • Added the prefer-numeric-literals rule to eslint.config.js

Testing

  • Verified the rule was added correctly by running lint checks
  • No code changes were needed as the codebase already follows this rule

Link to Devin run: https://app.devin.ai/sessions/8ac195f3effa48029307adc71d0d1699
Requested by: Razvan Marescu (razvan@marescu.net)

Co-Authored-By: Razvan Marescu <razvan@marescu.net>
Copy link
Contributor Author

Original prompt from Razvan:

Received message in Slack channel #shortest:

@Devin, for antiwork/shortest, add the following eslint rule: "prefer-numeric-literals": "error"

Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shortest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 3:31am

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@rmarescu rmarescu merged commit 81ecc72 into main Apr 1, 2025
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this to Done in Shortest Apr 1, 2025
@rmarescu rmarescu deleted the devin/1743477448-add-eslint-rule branch April 1, 2025 03:30
@rmarescu rmarescu added this to the v0.4.10 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant