Skip to content

feat: improve init experience #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

feat: improve init experience #412

merged 1 commit into from
Mar 28, 2025

Conversation

rmarescu
Copy link
Member

Adds a task list to manage the installation steps.

In preparation for creating a more interactive setup with prompts.

CleanShot.2025-03-28.at.13.21.04.mp4

Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shortest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 8:24pm

@rmarescu rmarescu added this to the v0.4.9 milestone Mar 28, 2025
@rmarescu rmarescu marked this pull request as ready for review March 28, 2025 20:39
@@ -49,6 +49,7 @@
"commander": "^13.1.0",
"glob": "^10.4.5",
"globby": "^14.1.0",
"listr2": "^8.2.5",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked this one as it can be used with @inquirer/prompts via an adapter

Comment on lines +53 to +56
ctx.alreadyInstalled = !!(
packageJson?.dependencies?.["@antiwork/shortest"] ||
packageJson?.devDependencies?.["@antiwork/shortest"]
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserving existing functionality to exit early if the package is detected. Ref #297 (comment)

@rmarescu rmarescu merged commit c7c3b08 into main Mar 28, 2025
6 checks passed
@rmarescu rmarescu deleted the rmarescu/init-listr branch March 28, 2025 20:40
@github-project-automation github-project-automation bot moved this to Done in Shortest Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant