Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

PHP8 attributes and Gedmo #29

Open
@tacman

Description

I quite like php8 attributes -- the error messages are now MUCH clearer, instead of getting an DocParse error with no reference to what line caused the failure, the offending line shows up in the IDE (and course, when parsed).

However, the Gedmo traits assume annotation-style declarations:

trait NestedSetEntity
{
    /**
     * @var int
     * @Gedmo\TreeRoot
     * @ORM\Column(name="root", type="integer", nullable=true)
     */
    private $root;

I don't think it's possible to mix-and-match, or at least I'm having trouble doing so.

I'm replacing the provided trait with my own, but bringing up the issue here, because with PHP8 out and Doctrine 3 imminent (and Doctrine 2.9 out), maybe you'd consider a major version bump of this bundle, like you did when you originally forked it from stof.

Is there a way to used Gedmo attributes now, e.g.

#[Gedmo\TreeRoot]

The mechanics of php8 attribute support are pretty straightforward, but the decision about versioning is a bit trickier.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions