Skip to content

Resolving issue#30 for antidot-framework #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

peter279k
Copy link
Member

Description

It's related to antidot-framework/antidot-framework#30.

Motivation and context

As the above issue.

How has this been tested?

N/A

Screenshots (if appropriate)

N/A

@peter279k
Copy link
Member Author

Just notice that this PR is for the BC break and it should cause static analysis tool (Psalm) has issues.

@kpicaza
Copy link
Member

kpicaza commented Jan 24, 2021

We need the change in the Application interface first to be able to pass the pipeline. Nice work;-D

@kpicaza kpicaza self-requested a review January 24, 2021 21:03
@kpicaza kpicaza self-assigned this Jan 24, 2021
@kpicaza kpicaza added the enhancement New feature or request label Jan 24, 2021
@kpicaza kpicaza modified the milestones: 1.0.0, 2.0.0 Jan 24, 2021
@kpicaza
Copy link
Member

kpicaza commented Jan 24, 2021

Hi @peter279k, I merged the breaking change in the main branch. You need to rebase the main branch with your current branch(I can't rebase from the UI).

git checkout 2.x.x
git fetch
git pull [REMOTE_NAME] 2.x.x
git checkout fix_route_param_orders
git rebase 2.x.x
git push origin fix_route_param_orders --force-with-lease 

I think that it should fix every step in the pipeline. Thanks for your great work;-D

@kpicaza kpicaza merged commit 403c7dc into antidot-framework:2.x.x Jan 26, 2021
@peter279k
Copy link
Member Author

@kpicaza, sorry. I almost forget that. Is there any problem when merging this PR?

@kpicaza
Copy link
Member

kpicaza commented Jan 26, 2021

No, there is another breaking change from an internal perspective I added in this PR antidot-framework/antidot-framework#17, and forget it, this PR is perfect;-D Thanks a lot for your help.

@peter279k peter279k deleted the fix_route_param_orders branch January 27, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants