feat(devcontainer): enhance firewall with hybrid static/dynamic IP management #5609
+55
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement - Implement dual IPSet approach (static for GitHub, dynamic for others) - Add automatic DNS refresh with TTL support (600s default) - Improve maintainability with single domain array configuration - Pass domains as arguments to refresh script (avoid duplication) - Reduce verbose logging while keeping error messages
MarkS-AL
reviewed
Aug 29, 2025
| IFS=$'\n\t' # Stricter word splitting | ||
|
|
||
| # Configuration - Domain list as shell array for easy maintenance | ||
| declare -a DYNAMIC_DOMAINS=( |
There was a problem hiding this comment.
Allow additional domains, eg "pypi.org" to be passed in externally, eg via WHITELIST_DOMAINS env var?
Concat the user whitelist with this list of domain names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the DevContainer firewall configuration to better handle modern CDN
and load-balanced services by implementing a hybrid approach for IP management.
Changes
Hybrid IP Management:
Automatic Updates:
Improved Maintainability:
Testing
Tested in Docker container with the following results:
Backward Compatibility
allowed-domainsIPSet if exists