fix(hookify): make file rules match Write tool content#24321
Open
ashwingopalsamy wants to merge 1 commit intoanthropics:mainfrom
Open
fix(hookify): make file rules match Write tool content#24321ashwingopalsamy wants to merge 1 commit intoanthropics:mainfrom
ashwingopalsamy wants to merge 1 commit intoanthropics:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hookify file-rule matching so rules targeting
new_text(including legacyevent: file+pattern) also matchWritetool payloads.Before this change,
Writeoperations usedtool_input.content, butnew_textresolution only looked atnew_string, so file rules could miss new-file writes.Changes
Write/Edit,content/new_text/new_stringnow resolve consistently from:new_string(Edit), (or)content(Write).Test Plan
pattern: console\.log\(matches:Writeinput usingtool_input.contentEditinput usingtool_input.new_stringRisk
Low. Change is limited to
Write/Editfield mapping for file-rule evaluation and does not alter unrelated hook events.