fix: encode branch names in GitHub links - #1713
Open
Abdullah-Builds wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode branch names in GitHub links
Closes #1712
Summary
Fixes GitHub branch and compare links generated by the action when a valid branch name contains URL-significant characters such as
#.Branch names are now encoded one path segment at a time, so
/remains a branch hierarchy separator while#is encoded as%23instead of becoming a URL fragment.Changes
encodeBranchNameForUrl()for Git-ref URL paths.claude/fix#123.Example
Before:
After:
Validation
git diff --checktest/comments-common.test.ts