fix(settings): improve settings input validation and error diagnostics - #1689
Open
Juwan-Hwang wants to merge 1 commit into
Open
fix(settings): improve settings input validation and error diagnostics#1689Juwan-Hwang wants to merge 1 commit into
Juwan-Hwang wants to merge 1 commit into
Conversation
- Distinguish inline JSON from configuration file paths deterministically using syntax heuristics and filesystem resolution. - Provide clear, actionable syntax error messages when inline JSON is malformed instead of falling back to misleading file-not-found errors. - Validate that parsed settings conform to a JSON dictionary object (rejecting primitives and arrays). - Expand unit tests to cover malformed JSON, invalid schemas, and file error cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves input parsing, error handling, and diagnostic reporting in \setupClaudeCodeSettings\ (\�ase-action/src/setup-claude-code-settings.ts).
Problems Addressed
Previously, if a workflow author supplied an inline JSON string that contained a syntax error (such as a missing bracket, quote, or trailing comma), \JSON.parse\ failed and the loader immediately fell back to treating the entire string as a filesystem path. When
eadFile\ failed, an obscure \ENOENT: no such file or directory, open '{...'\ error was raised instead of reporting the actual JSON syntax error.
\JSON.parse\ can successfully parse non-object primitives or arrays (e.g. [1, 2, 3]\ or \123), which were then shallowly merged via { ...settings, ...inputSettings }\ without validating that \inputSettings\ is a valid object dictionary.
Introduced clean separation between inline JSON strings (detected via syntax prefix) and configuration file paths, providing precise diagnostic messages for:
Changes
Verification