fix: respect ANTHROPIC_BASE_URL for inline comment classification#1473
Open
Epochex wants to merge 1 commit into
Open
fix: respect ANTHROPIC_BASE_URL for inline comment classification#1473Epochex wants to merge 1 commit into
Epochex wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1418.
This updates the buffered inline comment classifier to build its Anthropic messages endpoint from
ANTHROPIC_BASE_URLwhen configured, while keeping the existinghttps://api.anthropic.com/v1/messagesdefault. It also normalizes trailing slashes so proxy/base URLs can be configured without producing a double slash.Validation run locally:
npx.cmd --yes bun@latest test ./test/post-buffered-inline-comments.test.tsnpx.cmd --yes bun@latest run typechecknpx.cmd prettier@3.5.3 --check src/entrypoints/post-buffered-inline-comments.ts test/post-buffered-inline-comments.test.tsgit diff --check