Repository navigation
fix: parse scientific-notation ceilings like the CLI - #1371
Open
Muhtasim-Munif-Fahim wants to merge 1 commit into
Open
Muhtasim-Munif-Fahim wants to merge 1 commit into
Muhtasim-Munif-Fahim wants to merge 1 commit into
Conversation
int() rejected values such as 1e6 that the CLI accepts, so the SDK silently fell back to the 600_000 ms default. Parse via float while still rejecting non-integral values. Fixes anthropics#1359
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_end_ceiling_msusedint(raw), so CLI-compatible values like1e6fell back to the 600_000 ms default. Parse viafloat(rejecting non-integrals) to match the CLI.Test plan
TestRunEndCeilingFromEnvwith1e6,1e2, and fractional rejectionFixes #1359