Repository navigation
feat(types): expose MCP server source in status - #1346
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
sigley
approved these changes
Oct 7, 2026
sigley
left a comment
There was a problem hiding this comment.
Reviewed on exact head 8cc6e3961e7acf89914ec3583a97e8547220a4df.
This looks sound to me. Query.get_mcp_status() already returns the control response verbatim, so the runtime path does not need a parser change; the missing piece is the public TypedDict/documentation surface. Keeping source as an optional open str also avoids freezing the SDK to only the currently observed "sdk" value, and the tests cover both that known value and an unrecognized future value through the public status path.
I did not find a correctness issue in the change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sourcetoMcpServerStatus."sdk"while allowing other values.Why
Implementation