Skip to content

feat(types): expose MCP server source in status - #1346

Open
fallintoplace wants to merge 1 commit into
anthropics:mainfrom
fallintoplace:feat/mcp-server-status-source
Open

fallintoplace wants to merge 1 commit into
anthropics:mainfrom
fallintoplace:feat/mcp-server-status-source

Conversation

@fallintoplace

Copy link
Copy Markdown

What

  • Add optional source to McpServerStatus.
  • Document "sdk" while allowing other values.

Why

  • Let callers see where each server came from.

Implementation

  • Keep the CLI response unchanged and cover known and unrecognized sources.

@sigley sigley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on exact head 8cc6e3961e7acf89914ec3583a97e8547220a4df.

This looks sound to me. Query.get_mcp_status() already returns the control response verbatim, so the runtime path does not need a parser change; the missing piece is the public TypedDict/documentation surface. Keeping source as an optional open str also avoids freezing the SDK to only the currently observed "sdk" value, and the tests cover both that known value and an unrecognized future value through the public status path.

I did not find a correctness issue in the change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants