Repository navigation
docs: include_hook_events names the SessionStart and Setup events the CLI emits regardless - #1336
Open
codyanthony736 wants to merge 1 commit into
Open
codyanthony736 wants to merge 1 commit into
codyanthony736 wants to merge 1 commit into
Conversation
… CLI emits regardless Docstring-only change. The option says it matches the TypeScript SDK's includeHookEvents, whose doc comment adds that the SessionStart and Setup hook events are emitted regardless of the setting. Confirmed against 0.2.160: with include_hook_events=False and a project-level SessionStart hook configured, the stream still carries HookEventMessage items for SessionStart.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
=======================================
Coverage ? 92.21%
=======================================
Files ? 25
Lines ? 4648
Branches ? 0
=======================================
Hits ? 4286
Misses ? 362
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docstring-only change; no behavior change.
ClaudeAgentOptions.include_hook_eventssays it matches the TypeScript SDK'sincludeHookEvents, whose doc comment adds that theSessionStartandSetuphook events are emitted regardless of the setting. The Python docstring now says the same.Confirmed against 0.2.160 in a container: with
include_hook_events=Falseand a project-levelSessionStarthook configured, the message stream still carriesHookEventMessageitems forSessionStart; with the flag on, the same items appear.Line reference at main 37422c2.