This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Await GoogleAuth to finish initialization #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that there is one more bug with this block of code. |
ievgennaida
approved these changes
Oct 15, 2020
|
You're right. It was there before but I'll fix it |
|
Pushed a fix |
ievgennaida
approved these changes
Oct 15, 2020
ievgennaida
approved these changes
Oct 15, 2020
santhosh-rajashekar
approved these changes
Oct 16, 2020
|
Ill try to get this reviewed this afternoon. |
|
Thank you for the PR, i have noticed another bug in the sign out that I will push after i merge this. |
anthonyjgrove
approved these changes
Oct 19, 2020
|
This issue was fixed by this merge: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
GoogleAuth is defined but not yet initialized completely, we should use the thenable version of it instead.