feat: block type enum #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
force-pushed
the
feat-block-type
branch
from
ab67634 to
8deb185
Compare
Autoparallel
force-pushed
the
feat-block-type
branch
from
8deb185 to
4f794bc
Compare
0xJepsen
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give an overview of the tasks completed
Provides an upgraded API for handling block updates with added user control, i.e.:
update_blockfunction for the environment.Provides an ability to procedurally update block timestamps when using
BlockType::RandomlySampled. Furthermore, gives the ability to update block timestamps via theupdate_blockfunction as well.Furthermore, there is a refactor of the comms used in
RevmMiddlewaretoEnvironmentwhich feels much cleaner to me.Link to issue(s) that this PR closes
Closes #418 and closes #464
NOTE THAT THIS SHOULD COME AFTER #478 AS IT IS FORKED FROM THAT HEAD