Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment stop #459

Merged
merged 8 commits into from
Aug 23, 2023
Merged

fix: environment stop #459

merged 8 commits into from
Aug 23, 2023

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
This PR provides a quick fix to the Manager::stop_environment() method by replacing tx_receiver.recv() with tx_receiver.try_recv().

Link to issue(s) that this PR closes
Closes #456


Please merge after #458

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #459 (81bfd85) into main (880525e) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 81bfd85 differs from pull request most recent head c9300e5. Consider uploading reports for the commit c9300e5 to get more accurate results

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   58.00%   58.00%           
=======================================
  Files          10       10           
  Lines        3022     3022           
=======================================
  Hits         1753     1753           
  Misses       1269     1269           
Files Changed Coverage Δ
arbiter-core/src/manager.rs 62.09% <ø> (ø)
arbiter-core/src/middleware.rs 84.52% <ø> (ø)
arbiter-core/src/environment.rs 77.61% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! When we get CI to pass i'll merge in!

@Autoparallel Autoparallel merged commit 83fe4dc into main Aug 23, 2023
@Autoparallel Autoparallel deleted the fix-environment-stop branch August 28, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the method stop_environment() on Manager hangs
2 participants