fix(hgraph): remove ef_search topk upper bound#2515
Open
wxyucs wants to merge 1 commit into
Open
Conversation
Allow HGraph searches to use any positive int64 ef_search without a k-relative cap. Preserve signed integer range checks, lower-bound validation, and overflow-safe hops_limit handling. Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com> Assisted-by: Codex:GPT-5
wxyucs
added
kind/bug
Collaborator
|
/label S-waiting-on-review |
vsag-bot
self-requested a review
July 23, 2026 03:46
Collaborator
|
Automated pull request review completed. Review effort: No actionable inline findings were found. |
Contributor
Merge Protections🟢 All 3 merge protections satisfied — ready to merge. Show 3 satisfied protections🟢 Require kind label
🟢 Require version label
🟢 Require linked issue for feature/bug PRs
|
vsag-bot
reviewed
Jul 23, 2026
vsag-bot
left a comment
vsag-bot
left a comment
Collaborator
There was a problem hiding this comment.
Automated inline review completed.
Review effort: low (36 changed lines across 4 files).
No actionable inline findings were found.
Reviewed commit 66db30d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2409
Rationale
HGraph currently rejects positive
ef_searchvalues abovemax(10 * topk, 1000), preventing larger candidate frontiers for large-limit and highly selective workloads. The search implementation already represents the frontier asint64_t/uint64_t, so the k-relative cap is unnecessary.Behavior change
int64_tHGraphef_search; remove only the k-relative upper bound.INT64_MAX.hops_limitcomparison overflow-safe whenef_searchexceedsuint32_t.Test plan
ef_search=1001withtopk=3succeeds; zero and negative values are rejected.[hgraph]functional coverage: 7 cases passed; one long daily build/continue-add case was interrupted after 171.874s.make releasepassed.make lintpassed with clang-tidy 15; direct clang-tidy 15 on changed implementations passed.git diff --checkpassed.