feat: allow selecting inner index label remap map (cherry-pick #1981 to 0.18)#2029
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable label remapping mechanism within the LabelTable, allowing for different map implementations like PG and ROBIN. It refactors LabelTable to support hole management, adds a RemoveListFilter for tracking deletions, and updates HGraph and InnerIndex parameters accordingly. The review identifies several critical issues: the logic for RecoverRemove and IsTombstoneLabel is broken because MarkRemove no longer updates the remap table with tombstones; RemoveListFilter may lead to dangling references if it outlives the LabelTable; and MergeOther fails to merge deleted ID information. Additionally, the reviewer noted inefficient locking within a loop and several indentation violations of the style guide.
6018f2e to
6f7bb35
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## 0.18 #2029 +/- ##
==========================================
+ Coverage 90.82% 91.49% +0.66%
==========================================
Files 330 330
Lines 19483 19574 +91
==========================================
+ Hits 17696 17909 +213
+ Misses 1787 1665 -122
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Summary
This is a cherry-pick of PR #1981 to branch 0.18.
Original PR: #1981
Changes from original PR:
Cherry-pick adaptations:
Closes #1986 (original issue)