Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated exports to support both esm and cjs typescript output #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamtomcat
Copy link

Description

When I was trying to use local-pkg in a commonjs module typescript was throwing an error that it was only finding the esm version of the library. This could totally be my misunderstanding of how exports works, but this change got things working.

Linked Issues

Additional context

@antfu
Copy link
Member

antfu commented Sep 11, 2024

I heard it's easier to remove the directly types field, and TypeScript would search for it automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants