Create rails generator for initial config. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution 👍 ! Great feature indeed. Do you mind adding a spec for the installer, so we can make sure it will pass against all supported rails versions? |
|
FYI, I'm waiting on this to resolve: stevehodgkiss/generator_spec#39 |
sunnyrjuneja
force-pushed
the
generator
branch
from
9e9ce3c
to
b060865
Compare
|
@antek-drzewiecki Branch is updated with a spec for the installer. Let me know if there's anything else do to improve this PR. |
|
Its great like it is! Once I tested and merged the Doorkeeper 2.0 branch ill merge this one. Expect it on Thursday as a maximum. |
|
Thanks again for your wonderful library and making it easy to contribute to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.