Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion in antchfx/xmlquery#15
This pull-request proposes a function;
as an alternative to
This allows for more readable xpath expressions without relying on prefix values. For example:
Using
Compile("//a:tag")
is not desirable becausea:
is not guaranteed to not change, and does not matchb:
. Namespaces in XML says:A current workaround is
Compile("//*[local-name()='tag' and namespace-uri()='example.com/tag']")
which quickly gets messy.I propose
CompileWithNS("//e:tag", map[string]string{"e": "example.com/tag"})
which scales better since namespace bindings can be reused.