Repository navigation
Apply boolean coercion to equality comparisons - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equality currently converts booleans to numbers:
2 = true()returns false,'' = false()returns false, and a nonempty node-set can compare unequal to true depending on its text.XPath 1.0 section 3.4 requires boolean conversion for equality/inequality when either operand is boolean, including node-set operands. Route those comparisons through
asBool, treating NaN as false. Other comparison dispatch remains unchanged.Adds 36 public expression cases covering both operand orders, numbers (including NaN), strings, and empty/nonempty node-sets; 20 fail before the fix. Corrects 14 existing equality expectations in
TestBooleanComparison; all expressions in that table were independently checked against lxml/libxml2 using the same XML fixture. This complements #151's operand-order fix for relational comparisons.Validation:
go test -race -covermode=atomic -coverprofile=/tmp/xpath-bool.cover ./...(85.0% coverage),go vet ./..., and Go 1.14.15go test ./...pass.git diff --checkpasses.AI-assisted implementation and validation.