-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory leak or endless loop in v1.3.0 #98
Comments
v1.3.0 changes a lot of code. https://github.com/antchfx/xpath/commits/master/ The best way is give your xpath expression to cause CPU high, let me test it. |
can you remove this code to disable caches and test again? Line 96 in 4b4638b
|
I noticed 1.3.1 removed that loop. I have tested these upgrades
the v1.3.1 CPU and memory is ok |
I guess the high CPU is caused by the thread deadlock when application run in the multiple goroutines that reused cached expr object. so I removed those loop code. antchfx/htmlquery#58 |
agree. our app use xpath inside go { } a lot. |
after upgrade xpath v1.2.5 => v1.3.0 ( not change anything else)
our app memory keep increasing until OOM and CPU keeps 100%
I found a new loop was added in func (t *NodeIterator) MoveNext() bool
is it cause endless loop in some case?
The text was updated successfully, but these errors were encountered: