Skip to content

Set Video Target Resolution to Device’s Native Screen Size by Default #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set Video Target Resolution to Device’s Native Screen Size by Default #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ Build/

# Ignore Xcode Cache
xcuserdata/
*.entitlements
*.pbxproj
4 changes: 1 addition & 3 deletions ScreenShare/ScreenShare.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
<plist version="1.0">
<dict>
<key>com.apple.security.application-groups</key>
<array>
<string>group.io.antmedia.ios.webrtc-sample.screen.share</string>
</array>
<array/>
</dict>
</plist>
4 changes: 1 addition & 3 deletions WebRTC-Sample-App/WebRTC-Sample-App.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
<plist version="1.0">
<dict>
<key>com.apple.security.application-groups</key>
<array>
<string>group.io.antmedia.ios.webrtc-sample</string>
</array>
<array/>
</dict>
</plist>
4 changes: 1 addition & 3 deletions WebRTC-Sample-App/WebRTC-Sample-AppDebug.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
<plist version="1.0">
<dict>
<key>com.apple.security.application-groups</key>
<array>
<string>group.io.antmedia.ios.webrtc-sample</string>
</array>
<array/>
</dict>
</plist>
44 changes: 22 additions & 22 deletions WebRTCiOSSDK.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@
CODE_SIGN_ENTITLEMENTS = ScreenShare/ScreenShare.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = ScreenShare/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = ScreenShare;
Expand All @@ -820,7 +820,7 @@
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = "io.antmedia.ios.webrtc-sample.screen.share";
PRODUCT_BUNDLE_IDENTIFIER = "io.sbd.ios.webrtc-sample.screen.share";
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_EMIT_LOC_STRINGS = YES;
Expand All @@ -835,7 +835,7 @@
CODE_SIGN_ENTITLEMENTS = ScreenShare/ScreenShare.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = ScreenShare/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = ScreenShare;
Expand All @@ -847,7 +847,7 @@
"@executable_path/../../Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = "io.antmedia.ios.webrtc-sample.screen.share";
PRODUCT_BUNDLE_IDENTIFIER = "io.sbd.ios.webrtc-sample.screen.share";
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_EMIT_LOC_STRINGS = YES;
Expand Down Expand Up @@ -985,7 +985,7 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEFINES_MODULE = YES;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
Expand Down Expand Up @@ -1021,7 +1021,7 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEFINES_MODULE = YES;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
DYLIB_COMPATIBILITY_VERSION = 1;
DYLIB_CURRENT_VERSION = 1;
DYLIB_INSTALL_NAME_BASE = "@rpath";
Expand Down Expand Up @@ -1056,11 +1056,11 @@
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.antmedia.ios.WebRTCiOSSDKTests;
PRODUCT_BUNDLE_IDENTIFIER = io.sbd.ios.WebRTCiOSSDKTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
Expand All @@ -1074,11 +1074,11 @@
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.antmedia.ios.WebRTCiOSSDKTests;
PRODUCT_BUNDLE_IDENTIFIER = io.sbd.ios.WebRTCiOSSDKTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
Expand All @@ -1096,7 +1096,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = "WebRTC-Sample-App/Info.plist";
INFOPLIST_KEY_CFBundleDisplayName = "WebRTC Sample";
Expand All @@ -1113,7 +1113,7 @@
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = "io.antmedia.ios.webrtc-sample";
PRODUCT_BUNDLE_IDENTIFIER = "io.sbd.ios.webrtc-sample";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -1135,7 +1135,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 2YK9J8G25K;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = "WebRTC-Sample-App/Info.plist";
INFOPLIST_KEY_CFBundleDisplayName = "WebRTC Sample";
Expand All @@ -1152,7 +1152,7 @@
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = "io.antmedia.ios.webrtc-sample";
PRODUCT_BUNDLE_IDENTIFIER = "io.sbd.ios.webrtc-sample";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
Expand All @@ -1171,11 +1171,11 @@
BUNDLE_LOADER = "$(TEST_HOST)";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = MJU7KX4L7S;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.antmedia.ios.webrtc.sample.AppTests;
PRODUCT_BUNDLE_IDENTIFIER = io.sbd.ios.webrtc.sample.AppTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
Expand All @@ -1191,11 +1191,11 @@
BUNDLE_LOADER = "$(TEST_HOST)";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = MJU7KX4L7S;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.antmedia.ios.webrtc.sample.AppTests;
PRODUCT_BUNDLE_IDENTIFIER = io.sbd.ios.webrtc.sample.AppTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
Expand All @@ -1210,11 +1210,11 @@
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = MJU7KX4L7S;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.antmedia.ios.webrtc.sample.AppUITests;
PRODUCT_BUNDLE_IDENTIFIER = io.sbd.ios.webrtc.sample.AppUITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
Expand All @@ -1229,11 +1229,11 @@
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = MJU7KX4L7S;
DEVELOPMENT_TEAM = 84D2TM7KGZ;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = io.antmedia.ios.webrtc.sample.AppUITests;
PRODUCT_BUNDLE_IDENTIFIER = io.sbd.ios.webrtc.sample.AppUITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
Expand Down
21 changes: 19 additions & 2 deletions WebRTCiOSSDK/api/AntMediaClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,25 @@ open class AntMediaClient: NSObject, AntMediaClientProtocol {

private var cameraPosition: AVCaptureDevice.Position = .front

private var targetWidth: Int = 1_280
private var targetHeight: Int = 720
private var targetWidth: Int = {
guard let activeView = (UIApplication.shared.connectedScenes.first as? UIWindowScene)?.windows.first else {
return .zero
}

let nativeBounds = activeView.screen.nativeBounds

return Int(nativeBounds.width.rounded(.down))
}()

private var targetHeight: Int = {
guard let activeView = (UIApplication.shared.connectedScenes.first as? UIWindowScene)?.windows.first else {
return .zero
}

let nativeBounds = activeView.screen.nativeBounds

return Int(nativeBounds.height.rounded(.down))
}()

private var maxVideoBps: NSNumber = 0

Expand Down