Skip to content

Talking feature #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Conversation

MuhammadjonTohirov
Copy link
Contributor

Are you talking, I just extracted audio level from rtc statistics, it's up to developer to implement are you talking feature. There is a delegate func audioLevelChanged(_ client: AntMediaClient, audioLevel: Double, hasAudio: Bool), and this method should let developer to know that audio level and it's status. if audio level has some value and hasAudio is false, it means that use muted the mic and tring to speak

…'s up to developer to implement are you talking feature. There is a delegate , and this method should let developer to know that audio level and it's status. if audio level has some value and hasAudio is false, it means that use muted the mic and tring to speak
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MuhammadjonTohirov,
I would like to congratulate you. This PR has much more better from the previous one.
Here are the points that I see as improvement

  • You've updated the .gitignore
  • You've removed the local files that I sent previously.
  • You've made your branch up to date.
  • Your PR focuses on a specific feature then it's easy to merge/review

Things to improve

  • It seems you deleted project.pbxproj which is required to open the project. Please correct me if I'm wrong
  • I've added comment for the audioLevelChanged method to make life easy for developers
  • I've invalidated timer in registerAudioLevelExtractor to not encounter multiple timers run at the same time accidently.
  • I've let the developer manage registerAudioLevelExtractor/removeAudioLevelExtractor with his own timeInterval

Please let me know if you think differently or you have feedbacks/forwards for me

Thank you, Cheers
Oguz

@mekya mekya merged commit bdd8f09 into ant-media:master Jun 1, 2024
@mekya mekya mentioned this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants