Repository navigation
fix(select): preserve object search callback pipeline - #9711
chenshuai2144 merged 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughSearchSelect 将请求、搜索回调和搜索值更新集中到统一处理器,并调整对象形式 ChangesSearchSelect 搜索处理
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change restores object-form search callbacks to the request pipeline while preserving disabled-fetch behavior and aligning focus resets. No actionable merge-blocking risk is identified; merge after normal checks pass. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change restores search behavior using the application's existing request callback. The remote-fetch setting and callback precedence remain enforced, and no new privileged access or security-control bypass was identified. Authorization within application-specific request handlers was not assessed. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 小兔敲下搜索词, Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9711 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 422 422
Lines 12161 12161
Branches 4461 4463 +2
=======================================
Hits 10719 10719
Misses 1284 1284
Partials 158 158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
When
SearchSelectreceivesshowSearch={{ onSearch }}, rc-select gives the object callback precedence over the top-level callback. This skips ProComponents' wrapper: typing calls the consumer callback but never forwards the keyword torequestor updates ProComponents' search state.searchOnFocusalso still calls the deprecated top-level callback instead of the resolved object callback.Compose the existing search handler into the object configuration and reuse the resolved callback for focus resets. Boolean search behavior and
fetchDataOnSearch={false}remain covered by controls. This is a remaining callback-composition bug after #9680, separate from the superseded #9689 feature-support patch and #9706's top-level prop feature.Validation on signed/GitHub-Verified head
e2aecd9510cb75e4710be7d9ccb3a0ef641696d3, based on current master67ed7d4c37595bd1cd5c0709aff95d1531b7b486(Node 26.10.0 / pnpm 9.15.9 / Vitest 4.1.11):pnpm test: 122 files / 1,386 tests pass.pnpm tsc, focused ESLint/Prettier,git diff --check, and fullpnpm build(UMD, ES/CJS and declarations): pass.AI assistance: Codex helped reproduce the two failures, implement the callback composition, run validation, and prepare this PR. New-head upstream CI is separate from these local results.