-
Notifications
You must be signed in to change notification settings - Fork 80
fix: fix the issue of failed verification when content is cssvar #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @kimteayon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求修复了CSS Linter中的一个错误,该错误导致使用CSS变量的 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #235 +/- ##
=======================================
Coverage 94.53% 94.53%
=======================================
Files 32 32
Lines 2817 2818 +1
Branches 444 445 +1
=======================================
+ Hits 2663 2664 +1
Misses 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 修复了当 CSS content 属性值为 CSS 变量时,linter 错误报警的问题。修改是有效的,但我建议对正则表达式进行改进,使其更严格地遵循 CSS 自定义属性的命名规范,并移除一处多余的模板字符串用法。这将提高代码的健壮性和可读性。
* feat: remove compatibility under React v18 (#210) * 2.0.0-alpha.0 * 2.0.0-alpha.2 * feat: rm style tokenKey (#213) * feat: rm style tokenKey * test: fix test cases * chore: fix tsc * feat: remove wrapSSR * docs: update examples * feat: css var support hash (#214) * feat: css var support hash * chore: remove useless comment * chore: fix tsc * test: add test case * chore: rm only * chore: add useMemo back (#215) * docs: add first render demo (#216) * 2.0.0-alpha.3 * fix: should not clean token when token change (#217) * 2.0.0-alpha.4 * perf: cache effect (#218) * chore: bump father-plugin (#219) * chore: bump version to 2.0.0-alpha.5 * fix: Keep render order in ssr (#225) * chore: record updateTime * test: add test case * chore: bump father version * chore: bump version to 2.0.0-alpha.6 * feat: extractStyle support once (#228) * feat: support autoPrefix (#230) * chore: bump version to 2.0.0-alpha.7 * fix: not use func of autoPrefix * chore: fix lint * chore: bump version to 2.0.0-alpha.8 * fix: fix the issue of failed verification when content is cssvar (#235) * fix: content * fix: content * feat: 更新文档 * feat: 更新文档 * feat: 更新测试用例 * feat: 更新测试用例 * chore: fix lint * chore: bump version to 2.0.0-alpha.9 * test: update test case --------- Co-authored-by: 二货爱吃白萝卜 <smith3816@gmail.com> Co-authored-by: Mickey <951203214@qq.com>
修复当 css 的 content 为 cssvar时 的报错问题:
