Skip to content

feat: [v6] retire deprecated api for tabs #52768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

aojunhao123
Copy link
Contributor

🤔 This is a ...

  • 🛠 Refactoring

🔗 Related Issues

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 12, 2025

👁 Visual Regression Report for PR #52768 Failed ❌

🎯 Target branch: next (aaf384a)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎
📊 Summary: 🔄 2 changed

Expected (Branch next) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png
input-otp.compact.png input-otp.compact.png input-otp.compact.css-var.png input-otp.compact.css-var.png

Important

There are 2 diffs found in this PR: 🔄 2 changed.
Please check all items:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Preview is ready

Copy link

Walkthrough

This pull request focuses on refactoring by retiring deprecated APIs in the project. It involves significant changes to snapshot test files across multiple components, including card, config-provider, splitter, and tabs. The package.json file has been updated to replace the rc-tabs dependency with @rc-component/tabs.

Changes

Files Summary
components/card/tests/snapshots/*.snap Updated snapshot tests for card component, reducing redundant code.
components/config-provider/tests/snapshots/components.test.tsx.snap Updated snapshot tests for config-provider component, optimizing test cases.
components/splitter/tests/snapshots/*.snap Updated snapshot tests for splitter component, improving test efficiency.
components/tabs/tests/snapshots/*.snap Major updates to snapshot tests for tabs component, reflecting API changes.
package.json Replaced rc-tabs with @rc-component/tabs dependency.

Copy link

socket-security bot commented Feb 12, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rc-component/tabs@1.0.0 environment +2 272 kB zombiej

🚮 Removed packages: npm/adm-zip@0.5.16, npm/ali-oss@6.22.0, npm/antd-img-crop@4.24.0, npm/antd-style@3.7.1, npm/antd-token-previewer@2.0.8, npm/axios@1.7.9, npm/cheerio@1.0.0, npm/circular-dependency-plugin@5.2.2, npm/classnames@2.5.1, npm/cli-progress@3.12.0, npm/copy-to-clipboard@3.3.3, npm/cross-env@7.0.3, npm/cross-fetch@4.1.0, npm/cypress-image-diff-html-report@2.2.0, npm/dayjs@1.11.13, npm/dekko@0.2.1, npm/dotenv@16.4.7, npm/dumi-plugin-color-chunk@1.1.2, npm/dumi@2.4.18, npm/env-paths@3.0.0, npm/eslint-plugin-compat@6.0.2, npm/eslint-plugin-jsx-a11y@6.10.2, npm/eslint-plugin-react-refresh@0.4.19, npm/fast-glob@3.3.3, npm/fetch-jsonp@1.3.0, npm/html2sketch@1.0.2, npm/http-server@14.1.1, npm/husky@9.1.7, npm/identity-obj-proxy@3.0.0, npm/immer@10.1.1, npm/is-ci@4.1.0, npm/isomorphic-fetch@3.0.0, npm/jest-axe@9.0.0, npm/jest-canvas-mock@2.5.2, npm/jest-environment-jsdom@29.7.0, npm/jest-image-snapshot@6.4.0, npm/jest-puppeteer@11.0.0, npm/jest@29.7.0, npm/jquery@3.7.1, npm/jsdom@26.0.0, npm/jsonml-to-react-element@1.1.11, npm/jsonml.js@0.1.0, npm/lint-staged@15.4.3, npm/lodash@4.17.21, npm/lunar-typescript@1.7.7, npm/lz-string@1.5.0, npm/minimist@1.2.8, npm/mockdate@3.0.5, npm/node-notifier@10.0.1, npm/open@10.1.0, npm/ora@8.2.0, npm/p-all@5.0.0, npm/package-manager-detector@0.2.9, npm/pixelmatch@6.0.0, npm/pngjs@7.0.0, npm/prettier@3.5.0, npm/prismjs@1.29.0, npm/puppeteer@24.2.0, npm/rc-cascader@3.33.0, npm/rc-checkbox@3.5.0, npm/rc-drawer@8.0.0, npm/rc-dropdown@4.2.1, npm/rc-image@7.11.0, npm/rc-input-number@9.4.0, npm/rc-input@1.7.2, npm/rc-mentions@2.19.1, npm/rc-menu@9.16.0, npm/rc-motion@2.9.5, npm/rc-notification@5.6.3, npm/rc-pagination@5.1.0, npm/rc-picker@4.11.1, npm/rc-progress@4.0.0, npm/rc-rate@2.13.1, npm/rc-resize-observer@1.4.3, npm/rc-select@14.16.6, npm/rc-slider@11.1.8, npm/rc-steps@6.0.1, npm/rc-switch@4.1.0, npm/rc-tabs@15.5.1, npm/rc-textarea@1.9.0, npm/rc-tree-select@5.27.0, npm/rc-tree@5.13.0, npm/rc-upload@4.8.1, npm/rc-util@5.44.4, npm/react-dom@19.0.0, npm/react@19.0.0, npm/scroll-into-view-if-needed@3.1.0, npm/throttle-debounce@5.0.2

View full report↗︎

Copy link

pkg-pr-new bot commented Feb 12, 2025

Copy link

codecov bot commented Feb 12, 2025

Bundle Report

Changes will increase total bundle size by 7.88MB (210.31%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
antd.min-array-push 11.62MB 7.88MB (210.31%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.js (New) 6.06MB 6.06MB 100.0% 🚀
antd.js (New) 5.56MB 5.56MB 100.0% 🚀
antd-with-locales.min.js (Deleted) -2.03MB 0 bytes -100.0% 🗑️
antd.min.js (Deleted) -1.72MB 0 bytes -100.0% 🗑️

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aaf384a) to head (18fd6d6).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #52768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          765       765           
  Lines        13768     13768           
  Branches      3601      3601           
=========================================
  Hits         13768     13768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thinkasany
thinkasany previously approved these changes Feb 13, 2025
@thinkasany thinkasany changed the title feat: retire deprecated api feat: [v6] retire deprecated api for tabs Feb 13, 2025
@thinkasany thinkasany merged commit 3273d7c into ant-design:next Feb 13, 2025
41 checks passed
@aojunhao123 aojunhao123 deleted the retire-tab branch February 13, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants