-
-
Notifications
You must be signed in to change notification settings - Fork 49.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refator: update rc-dialog to remove rc-animate
#26940
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 688e14e:
|
Size Change: -619 B (0%) Total Size: 793 kB
ℹ️ View Unchanged
|
重构 5 小时,修复测试 2 天。每个直接在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
效果看着不错。
Codecov Report
@@ Coverage Diff @@
## feature #26940 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 385 385
Lines 7409 7409
Branches 2023 2072 +49
========================================
Hits 7407 7407
Misses 2 2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只有单元测试,碰到 dom 和动画只能 hack ,😅
@shaodahong 这个合完了,你的 image 也升级一下依赖哈~~ |
理解错了,明白了,明天升级下 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge