Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Preview is ready

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在为 Dropdown 组件及其子组件 Dropdown.Item 提供统一且灵活的自定义类名前缀机制。通过集成 ConfigProvider 的 getPrefixCls 方法,组件现在能够响应全局配置的前缀,并允许开发者在单个组件实例上进行局部覆盖,从而增强了组件的可定制性和样式管理能力。

Highlights

  • 统一前缀类名管理: Dropdown 和 Dropdown.Item 组件现在通过 ConfigProvider 统一管理 prefixCls,允许全局配置组件的类名前缀。
  • 组件级前缀类名覆盖: Dropdown 组件新增 prefixCls 属性,支持在组件层面覆盖 ConfigProvider 提供的默认前缀,提供了更细粒度的控制。
  • 内部类名动态化: 移除了组件内部硬编码的 classPrefix 常量,所有相关的类名都动态地使用 getPrefixCls 方法生成,增强了灵活性和可维护性。
  • 测试用例增强: 增加了新的测试用例,验证了 ConfigProvider 和组件级 prefixCls 的正确应用,确保了功能的稳定性。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the feature label Oct 28, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 28, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6982

commit: de77c01

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (bfde19d) to head (de77c01).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6982      +/-   ##
===========================================
+ Coverage    92.95%   92.96%   +0.01%     
===========================================
  Files          337      337              
  Lines         7368     7368              
  Branches      1871     1861      -10     
===========================================
+ Hits          6849     6850       +1     
+ Misses         483      482       -1     
  Partials        36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在为 Dropdown 组件统一提供自定义 prefixCls 的能力。整体实现思路是正确的,通过 useConfiggetPrefixCls 来动态生成类名。然而,我发现一个关于 prefixCls 继承的问题:当给 Dropdown 组件设置 prefixCls 属性时,其子组件 Dropdown.Item 没有继承这个前缀,而是使用了来自 ConfigProvider 的全局前缀。这会导致父子组件的 class 前缀不一致。我在测试文件中指出了这个问题,并提供了修复建议。修复这个问题将能确保组件在各种场景下样式的一致性和可预测性。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant