-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(Dropdown): unified provision of custom prefixCls #6982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在为 Dropdown 组件及其子组件 Dropdown.Item 提供统一且灵活的自定义类名前缀机制。通过集成 ConfigProvider 的 getPrefixCls 方法,组件现在能够响应全局配置的前缀,并允许开发者在单个组件实例上进行局部覆盖,从而增强了组件的可定制性和样式管理能力。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6982 +/- ##
===========================================
+ Coverage 92.95% 92.96% +0.01%
===========================================
Files 337 337
Lines 7368 7368
Branches 1871 1861 -10
===========================================
+ Hits 6849 6850 +1
+ Misses 483 482 -1
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 旨在为 Dropdown 组件统一提供自定义 prefixCls 的能力。整体实现思路是正确的,通过 useConfig 和 getPrefixCls 来动态生成类名。然而,我发现一个关于 prefixCls 继承的问题:当给 Dropdown 组件设置 prefixCls 属性时,其子组件 Dropdown.Item 没有继承这个前缀,而是使用了来自 ConfigProvider 的全局前缀。这会导致父子组件的 class 前缀不一致。我在测试文件中指出了这个问题,并提供了修复建议。修复这个问题将能确保组件在各种场景下样式的一致性和可预测性。

统一添加自定义class 前缀
关联issue #6960