feat(Calendar): unified provision of custom prefixCls #6967
Conversation
dosubot
bot
added
the
size:L
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a standardized and flexible system for managing CSS class prefixes across components, beginning with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| test('should apply custom prefixCls', () => { | ||
| const { container } = render( | ||
| <ConfigProvider prefixCls='config-prefix'> | ||
| <Calendar /> | ||
| </ConfigProvider> | ||
| ) | ||
| expect(container.querySelector('.config-prefix-calendar')).toBeTruthy() | ||
| expect(container).toMatchSnapshot() | ||
| }) |
There was a problem hiding this comment.
config-provider 的测试文件不应该依赖 Calendar 这样的上层业务组件，这会造成不好的模块分层。建议移除对 Calendar 的导入，并使用一个简单的本地测试组件来代替，以实现测试的解耦。
test('should apply custom prefixCls', () => {
const DemoComponent = () => {
const { getPrefixCls } = useConfig()
const prefixCls = getPrefixCls('calendar')
return <div className={prefixCls} />
}
const { container } = render(
<ConfigProvider prefixCls='config-prefix'>
<DemoComponent />
</ConfigProvider>
)
expect(container.querySelector('.config-prefix-calendar')).toBeTruthy()
expect(container).toMatchSnapshot()
})
| const getPrefixCls = (suffixCls?: string, customizePrefixCls?: string) => { | ||
| if (customizePrefixCls) { | ||
| return customizePrefixCls | ||
| } | ||
| const mergedPrefixCls = | ||
| config.prefixCls || parentConfig.prefixCls || defaultPrefixCls | ||
| return suffixCls ? `${mergedPrefixCls}-${suffixCls}` : mergedPrefixCls | ||
| } |
There was a problem hiding this comment.
getPrefixCls 函数在每次 ConfigProvider 渲染时都会被重新创建。为了优化性能，避免下游消费组件不必要的重渲染，建议使用 React.useCallback 将其包裹起来进行 memoization。
const getPrefixCls = React.useCallback(
(suffixCls?: string, customizePrefixCls?: string) => {
if (customizePrefixCls) {
return customizePrefixCls
}
const mergedPrefixCls =
config.prefixCls || parentConfig.prefixCls || defaultPrefixCls
return suffixCls ? `${mergedPrefixCls}-${suffixCls}` : mergedPrefixCls
},
[config.prefixCls, parentConfig.prefixCls]
)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6967 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 337 337
Lines 7368 7368
Branches 1871 1835 -36
========================================
Hits 6849 6849
- Misses 483 511 +28
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyyyLiu
force-pushed
the
feature-prefixCls-calendar
branch
from
a4af119 to
8eaa8b6
Compare
EmilyyyLiu
force-pushed
the
feature-prefixCls-calendar
branch
from
6329689 to
4319bb2
Compare
dosubot
bot
added
size:M
1 participant
统一添加自定义class 前缀
关联issue #6960