-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(Badge): unified provision of custom prefixCls #6965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过引入统一的自定义类前缀机制来标准化组件的样式管理,首先从 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a unified way to provide a custom prefixCls for components, starting with the Badge component. The implementation correctly uses React's Context API via a ConfigProvider to allow for global and per-component prefix overrides. The changes are well-structured, include appropriate tests for the new functionality, and update the documentation. I have one minor suggestion for improvement.
| export const Badge: FC<BadgeProps> = props => { | ||
| const { content, color, children } = props | ||
| const { getPrefixCls } = useConfig() | ||
| const prefixCls = getPrefixCls('badge', props?.prefixCls) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The props object in a React functional component is guaranteed to be defined. Therefore, the optional chaining operator (?.) is not necessary here. You can safely access props.prefixCls directly for cleaner code.
| const prefixCls = getPrefixCls('badge', props?.prefixCls) | |
| const prefixCls = getPrefixCls('badge', props.prefixCls) |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6965 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 337 337
Lines 7368 7369 +1
Branches 1871 1871
========================================
+ Hits 6849 6850 +1
Misses 483 483
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0baa5c3 to
00422a9
Compare

统一添加自定义class 前缀
关联issue #6960