Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 21, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Preview failed

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在通过引入统一的自定义类前缀机制来标准化组件的样式管理,首先从 Badge 组件开始。这一改进使得用户能够通过 ConfigProvider 进行全局配置,或在组件级别进行局部定义,从而实现更灵活的样式和主题定制。

Highlights

  • 自定义类前缀支持: 为 Badge 组件引入了 prefixCls 属性,允许开发者自定义其 CSS 类前缀,从而实现更灵活的样式控制。
  • ConfigProvider 增强: 增强了 ConfigProvider,使其能够全局管理和提供 prefixCls 以及一个 getPrefixCls 函数,方便组件统一获取和应用前缀。
  • Badge 组件集成: Badge 组件现在利用 useConfigConfigProvider 获取 getPrefixCls 函数,并应用统一的前缀逻辑,确保样式的一致性。
  • 测试用例更新: 为 Badge 组件添加了新的测试用例,以验证通过 ConfigProvider 和组件自身属性设置自定义 prefixCls 的功能,确保其正确性。
  • 文档更新: 更新了 ConfigProvider 的英文和中文文档,以包含新的 prefixCls 属性,方便用户了解和使用此功能。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the feature label Oct 21, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a unified way to provide a custom prefixCls for components, starting with the Badge component. The implementation correctly uses React's Context API via a ConfigProvider to allow for global and per-component prefix overrides. The changes are well-structured, include appropriate tests for the new functionality, and update the documentation. I have one minor suggestion for improvement.

export const Badge: FC<BadgeProps> = props => {
const { content, color, children } = props
const { getPrefixCls } = useConfig()
const prefixCls = getPrefixCls('badge', props?.prefixCls)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The props object in a React functional component is guaranteed to be defined. Therefore, the optional chaining operator (?.) is not necessary here. You can safely access props.prefixCls directly for cleaner code.

Suggested change
const prefixCls = getPrefixCls('badge', props?.prefixCls)
const prefixCls = getPrefixCls('badge', props.prefixCls)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6965

commit: 00422a9

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (bfde19d) to head (00422a9).

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #6965   +/-   ##
========================================
  Coverage    92.95%   92.95%           
========================================
  Files          337      337           
  Lines         7368     7369    +1     
  Branches      1871     1871           
========================================
+ Hits          6849     6850    +1     
  Misses         483      483           
  Partials        36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyyyLiu EmilyyyLiu force-pushed the feature-prefixCls-badge branch from 0baa5c3 to 00422a9 Compare October 23, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant