Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dep #822

Merged
merged 8 commits into from
Apr 22, 2020
Merged

Upgrade dep #822

merged 8 commits into from
Apr 22, 2020

Conversation

BANG88
Copy link
Member

@BANG88 BANG88 commented Apr 20, 2020

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@BANG88
Copy link
Member Author

BANG88 commented Apr 21, 2020

@1uokun 我现在在升级依赖到最新版,并修复一些关联的bug。现在测试有问题,不知道你有没有空来一起看看。 或者换一个更好的测试方式

谢谢

@1uokun
Copy link
Collaborator

1uokun commented Apr 21, 2020

@BANG88 说实话你想到了第五层,而我还在第一层🤦‍♂️
下班后要不要帮你把部分组件迁移到react-native-community🤓

@BANG88
Copy link
Member Author

BANG88 commented Apr 21, 2020

@BANG88 说实话你想到了第五层,而我还在第一层🤦‍♂️
😭 我先弄了一下,升级好多问题。

下班后要不要帮你把部分组件迁移到react-native-community🤓

什么组件,暂时不想拆 之前拆了不好维护才合并的,现在主要就是修复bug, react-native 更新一次要麻烦一次。

@1uokun
Copy link
Collaborator

1uokun commented Apr 21, 2020

我刚拉你代码test跑下来报错的信息:

Warning: XXX has been extracted from react-native core and will be removed in a future release. 
It can now be installed and imported from '@react-native-community/XXX' instead of 'react-native'. 
See https://github.com/react-native-community/XXX

@BANG88
Copy link
Member Author

BANG88 commented Apr 21, 2020

我刚拉你代码test跑下来报错的信息:

Warning: XXX has been extracted from react-native core and will be removed in a future release. 
It can now be installed and imported from '@react-native-community/XXX' instead of 'react-native'. 
See https://github.com/react-native-community/XXX

upgrade-dep 分支,删掉 node_modules 重新安装,现在就是不知道是不是node的问题,还在查. 大部分能通过

@1uokun
Copy link
Collaborator

1uokun commented Apr 21, 2020

我刚拉你代码test跑下来报错的信息:

Warning: XXX has been extracted from react-native core and will be removed in a future release. 
It can now be installed and imported from '@react-native-community/XXX' instead of 'react-native'. 
See https://github.com/react-native-community/XXX

upgrade-dep 分支,删掉 node_modules 重新安装,现在就是不知道是不是node的问题,还在查. 大部分能通过

参考:facebook/react-native@7e23c7c

大概代码长这样:1uokun@b04dbdd

其他:
0.59.4+之后react-native取消了很多内置组件,比如swiper要引入的话要单独

- import { Swiper } from 'react-native'
+ import Swiper from '@react-native-community/picker'

还要link,不过这个版本之后变成自动link了

@BANG88
Copy link
Member Author

BANG88 commented Apr 21, 2020

我刚拉你代码test跑下来报错的信息:

Warning: XXX has been extracted from react-native core and will be removed in a future release. 
It can now be installed and imported from '@react-native-community/XXX' instead of 'react-native'. 
See https://github.com/react-native-community/XXX

upgrade-dep 分支,删掉 node_modules 重新安装,现在就是不知道是不是node的问题,还在查. 大部分能通过

参考:facebook/react-native@7e23c7c

大概代码长这样:1uokun@b04dbdd

其他:
0.59.4+之后react-native取消了很多内置组件,比如swiper要引入的话要单独

- import { Swiper } from 'react-native'
+ import Swiper from '@react-native-community/picker'

还要link,不过这个版本之后变成自动link了

明白你的意思了。 你是说把react-native里面分拆的组件,单独安装修改一下。 这个可以搞,我搞了两个,你看看还有什么要搞的。

安装依赖的时候记得 开发的时候装在dev依赖里面,但是peer里面的依赖也要有。

另外: tests 现在可以了,很奇葩的问题

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #822 into master will decrease coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   58.73%   58.70%   -0.03%     
==========================================
  Files         206      212       +6     
  Lines        5082     5081       -1     
  Branches     1110     1106       -4     
==========================================
- Hits         2985     2983       -2     
- Misses       2080     2081       +1     
  Partials       17       17              
Flag Coverage Δ
#rn 58.70% <80.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
components/progress/index.tsx 75.00% <ø> (ø)
components/tabs/Tabs.tsx 66.47% <66.66%> (-0.72%) ⬇️
components/notice-bar/Marquee.tsx 50.00% <100.00%> (ø)
components/tab-bar/index.tsx 100.00% <100.00%> (ø)
components/image-picker/CameraRollPicker.tsx 19.48% <0.00%> (-0.26%) ⬇️
components/list-view/locale/es_ES.tsx 100.00% <0.00%> (ø)
components/date-picker/datepicker/locale/ru_RU.tsx 100.00% <0.00%> (ø)
components/list-view/locale/sv_SE.tsx 0.00% <0.00%> (ø)
components/date-picker/datepicker/locale/sv_SE.tsx 0.00% <0.00%> (ø)
components/list-view/locale/ru_RU.tsx 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159fbdc...ca0ce5a. Read the comment docs.

@1uokun 1uokun mentioned this pull request Apr 21, 2020
@BANG88 BANG88 merged commit ff0abf7 into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the upgrade-dep branch April 22, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants