-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dep #822
Upgrade dep #822
Conversation
@1uokun 我现在在升级依赖到最新版,并修复一些关联的bug。现在测试有问题,不知道你有没有空来一起看看。 或者换一个更好的测试方式 谢谢 |
@BANG88 说实话你想到了第五层,而我还在第一层🤦♂️ |
什么组件,暂时不想拆 之前拆了不好维护才合并的,现在主要就是修复bug, react-native 更新一次要麻烦一次。 |
我刚拉你代码test跑下来报错的信息: Warning: XXX has been extracted from react-native core and will be removed in a future release.
It can now be installed and imported from '@react-native-community/XXX' instead of 'react-native'.
See https://github.com/react-native-community/XXX
|
upgrade-dep 分支,删掉 node_modules 重新安装,现在就是不知道是不是node的问题,还在查. 大部分能通过 |
参考:facebook/react-native@7e23c7c 大概代码长这样:1uokun@b04dbdd 其他:
还要link,不过这个版本之后变成自动link了 |
明白你的意思了。 你是说把react-native里面分拆的组件,单独安装修改一下。 这个可以搞,我搞了两个,你看看还有什么要搞的。 安装依赖的时候记得 开发的时候装在dev依赖里面,但是peer里面的依赖也要有。 另外: tests 现在可以了,很奇葩的问题 |
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 58.73% 58.70% -0.03%
==========================================
Files 206 212 +6
Lines 5082 5081 -1
Branches 1110 1106 -4
==========================================
- Hits 2985 2983 -2
- Misses 2080 2081 +1
Partials 17 17
Continue to review full report at Codecov.
|
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :