feat: @ctrl/tinycolor treeshaking #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 4af64a7 into aec928b - view on LGTM.com new alerts:
|
|
Coverage 应该没降，应该是因为行数涨了= = |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import functions from files instead of the index to make the bundle smaller.
I've test it with rollup, the output is treeshakable. About 20 kb less.
Before
After
Remove
ts-jestsince it won't transform modules fromnode_moduleseventransfromIgnorePatternsis set. Current config is the official way from jest to support typescript.https://jestjs.io/docs/en/getting-started#using-typescript