Open
Conversation
Fixes the off behaviour for home assistant using the off mode
I added a combined swing mode which also adds the possibility to change the horizontal swing mode as well vertical
Owner
|
Thanks! I'm a bit busy right now but I'll take a look in a few days |
Owner
|
I like the comments, but I have two issues with the PR. |
Contributor
Author
|
Ah sorry about that, I missed the spaces change. Looks like VScode did an auto format. Yes I wanted to make them separate and used the wrong branch. Wasn't sure if it's possible like that. If not I'll make the changes next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds comments to base.js and RAC_056905_WW.js
I wanted to do multiple PRs for the ease of allowing and declining certain changes