Update vpc resource names inline with issue #89. #90
Conversation
|
Are we going to add the moved block in so that it does not break existing uses? |
I believe this is going to be in another PR. This PR just changes the resource name. |
|
The agreed approach was to bump up a major version to not have to deal with the moved block, as far as I'm aware. |
Initial changes... more name changes to come.
Added aws_region_short
Added `data "aws_region" "current" {}`
chrisbloe
force-pushed
the
update_vpc_resource_names
branch
from
f8e3ae9 to
025dc07
Compare
|
This is my PR so I can't approve it, but I have checked and this looks good to me 👍 |
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 4.0" | ||
| version = ">= 5.14.0" |
There was a problem hiding this comment.
Could we document (in code, or in wiki) the reasoning/requirement behind minimum versions of providers? It will make it easier to understand cross-module provider requirements
| description = "The email address of the owner." | ||
|
|
||
| validation { | ||
| condition = can(match("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", var.owner)) |
There was a problem hiding this comment.
| condition = can(match("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", var.owner)) | |
| condition = can(regex("^.+@[^@]+\\.[^@]{2,}$", var.owner)) |
more permissive email validation (plus match doesn't exist)
| resource "aws_cloudwatch_log_group" "vpc_flow_logs" { | ||
| count = var.enable_vpc_flow_logs ? 1 : 0 | ||
|
|
||
| name = "${replace("AWS::Logs::LogGroup", "::", "-")}-${var.project_name}-${var.environment}-${local.aws_region_short}-vpc_flow_logs" |
There was a problem hiding this comment.
is there a reason to use replace like this throughout? Also should be lower case. Surely we should just use something like log_group-...
No description provided.