Timed one time passwords #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the action structure to delay vault unlocking until after user input is received in "add" operations.
This update refactors the application's error handling to use a custom Error type from vault::entities module instead of anyhow::Result for better control and consistency.
- Refactor several functions to improve the handling of the grep option. - Remove several unnecessary functions in the code to streamline the deletion and showing process.
Enhanced error handling in different action implementations including regular actions such as add, delete, show and import/export. Now returns clearer error messages to the user in case of failures. Also made changes to pass result from save_database to improve error handling.
- Improve documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timed one time passwords, i.e. support for 2nd factor authentication methods. It also refactors the code base significantly making it cleaner and better.