Rename ip_version field to be more correct #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
@paneu I agree 'V' in 'show ip bgp summary' is bgp version spoken to neighbor. To keep backward compatibilty this can be added as new field 'bgp_version' and we will deprecate old key in future release based on feedback |
The version in the output of show ip bgp summary is not signifying the IP version, but rather the BGP version. Change the name of the field in order to reflect this. Keep the old name so that it can be deprecated gracefully.
|
@gdpak I have reintroduced the field so both coexist at the moment. Please let me know if there is any way to annotate the old field as deprecated. |
|
Build failed.
|
|
@paneu I just went through this --signoff thing. Checkout your branch, then |
|
@paneu can you please update the PR, fixing the failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version in the output of show ip bgp summary is not signifying the IP version, but rather the BGP version. Change the name of the field in order to reflect this.
This does break backwards compatibility though, so please let me know how to proceed in such a case.