Correctly set etc path and allow cors config for jolokia #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidograzioli
added
the
bugfixes
guidograzioli
changed the title
guidograzioli
force-pushed
the
jolokia_etc_hashed_passwords
branch
from
25ee268 to
265f1b4
Compare
rpelisse
reviewed
Sep 7, 2022
| @@ -28,7 +28,12 @@ activemq_jolokia_url: "http://{{ activemq_host }}:{{ activemq_http_port }}/conso | |||
| activemq_console_url: "http://{{ activemq_host }}:{{ activemq_http_port }}/console/" | |||
| activemq_jvm_package: java-11-openjdk-headless | |||
| activemq_java_home: | |||
| activemq_java_opts: "-Xms512M -Xmx2G -XX:+PrintClassHistogram -XX:+UseG1GC -XX:+UseStringDeduplication -Dhawtio.disableProxy=true -Dhawtio.realm=activemq -Dhawtio.offline=true -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml " | |||
| activemq_java_opts: "{{ [ | |||
There was a problem hiding this comment.
@guidograzioli be careful, that's getting to complicated for default. Down the road, it might be better to assemble that (somehow) dynamically to be able to check all vars involved and ensure that the array does not blow up to the user.
There was a problem hiding this comment.
agreed... worth mentioning that's the current default value in amq
rpelisse
approved these changes
Sep 7, 2022
guidograzioli
force-pushed
the
jolokia_etc_hashed_passwords
branch
2 times, most recently
from
4e497b0 to
b76d4e9
Compare
guidograzioli
force-pushed
the
jolokia_etc_hashed_passwords
branch
from
b76d4e9 to
73fe64e
Compare
guidograzioli
force-pushed
the
jolokia_etc_hashed_passwords
branch
from
30ca3e9 to
f290535
Compare
guidograzioli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22 : Update sysconfig and default JAVA_ARGS
Fix #16 : correctly set HAWTIO_ROLE
Fix #24: new variables allow to config jolokia-access.xml
activemq_cors_allow_origin*://0.0.0.0*activemq_cors_strict_checkingTrue