Skip to content

Add activemq_ha_backup_failover_on_shutdown role parameter #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

guidograzioli
Copy link
Member

The new role parameter allows to control failover-on-shutdown in backup instances, not to be confused with activemq_ha_failover_on_shutdown.

Variable Description Default
activemq_ha_failover_on_shutdown For a master broker, determines whether to fail over to a slave if it is shut down true
activemq_ha_backup_failover_on_shutdown For a slave broker, this element determines whether it becomes the master in case the master is shut down false

Fix #200

@guidograzioli guidograzioli requested a review from rpelisse April 30, 2025 09:08
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

description: >
For a slave broker, this element determines whether it becomes the master in case the master is shut down.
default: false
type: 'bool'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency sake, shouldn't be type: "bool" instead of type: 'bool' ?

@guidograzioli guidograzioli merged commit 70556d4 into ansible-middleware:main Apr 30, 2025
28 checks passed
@guidograzioli guidograzioli added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Apr 30, 2025
@guidograzioli guidograzioli changed the title Add parameter activemq_ha_backup_failover_on_shutdown Add activemq_ha_backup_failover_on_shutdown role parameter Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add failover-on-shutdown to backup broker for shared storage configuration
2 participants