Skip to content

wait_for_log: tail follows logfile with retry #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

wait_for_log: tail follows logfile with retry #225

merged 2 commits into from
Apr 30, 2025

Conversation

guidograzioli
Copy link
Member

@guidograzioli guidograzioli commented Apr 30, 2025 •
edited
Loading

New role parameters allow to control whether cron logfile rotation trigger is evaluated when starting the service up:

Variable Description Default
activemq_logger_cron_eval_on_startup Evaluate cron log rotation when starting service up true
activemq_logger_audit_cron_eval_on_startup Evaluate audit cron log rotation when starting service up true

Also, the wait_for_log logic uses tail with retry

Fix #203

@guidograzioli guidograzioli added bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix and removed bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements labels Apr 30, 2025
@guidograzioli guidograzioli requested a review from rpelisse April 30, 2025 08:23
rpelisse
rpelisse approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidograzioli guidograzioli merged commit 698891f into ansible-middleware:main Apr 30, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpelisse rpelisse rpelisse approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

be able to configure appender.log_file.policies.cron.evaluateOnStartup from the ansible role
2 participants
@guidograzioli @rpelisse