Skip to content

Fix user roles have to be unique in artemis-roles.properties #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fix user roles have to be unique in artemis-roles.properties #217

merged 1 commit into from
Mar 13, 2025

Conversation

RanabirChakraborty
Copy link
Member

@RanabirChakraborty RanabirChakraborty commented Mar 3, 2025 •
edited
Loading

@RanabirChakraborty RanabirChakraborty mentioned this pull request Mar 3, 2025
Closed
@4nt01ne
Copy link
Contributor

4nt01ne commented Mar 6, 2025

@rpelisse this PR was initially mine (#208) but did it from the main branch. I did it in draft because I was unsure if anything else was required like extending tests to be accepted.
@RanabirChakraborty proposed to create a PR from his is side to fix that.
Imo it should not be draft anymore

@rpelisse
Copy link
Contributor

rpelisse commented Mar 6, 2025

@4nt01ne thanks for the info!

@RanabirChakraborty did this PR passed our internal CI? If so, add the links to the issue (not here)

@4nt01ne
Copy link
Contributor

4nt01ne commented Mar 13, 2025

Hi @guidograzioli and @rpelisse.
What need to be done to move on this issue?
Can I help further?
We are using the amq-broker downstream and our roles list is seriously polluted.

@rpelisse
Copy link
Contributor

@4nt01ne If you are using the downstream collection, can you fill an issue with Red Hat support? That will certainly help speed things up :) Thanks!

@4nt01ne
Copy link
Contributor

4nt01ne commented Mar 13, 2025

@rpelisse, the case has just been opened at Red Hat.
For the one having access, its has # 04085970

rpelisse
rpelisse approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpelisse rpelisse merged commit ebae199 into ansible-middleware:main Mar 13, 2025
26 checks passed
@rpelisse rpelisse added the minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix label Mar 13, 2025
@guidograzioli guidograzioli changed the title AMW-369 In amq collection user roles have to be unique Fix user roles have to be unique Apr 22, 2025
@guidograzioli guidograzioli changed the title Fix user roles have to be unique Fix user roles have to be unique in artemis-roles.properties Apr 22, 2025
@guidograzioli guidograzioli mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpelisse rpelisse rpelisse approved these changes

Assignees

@RanabirChakraborty RanabirChakraborty

Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RanabirChakraborty @4nt01ne @rpelisse