Add a size based roll over of artemis and audit log files #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanabirChakraborty
force-pushed
the
sizebased_rollover
branch
from
803228e to
d6f4d13
Compare
|
@rpelisse please review. |
|
@RanabirChakraborty Thank you for the pull request. This would help us. I can't do a full review, but I noticed there are some failing checks. Maybe you can fix them already before @rpelisse starts a review? |
|
@michie1 Yeah there are some sudo permission changes happened from GitHub side, that's why we are seeing the CI failures. I have sent the fix, after that gets merged I'll rebase this PR. |
RanabirChakraborty
force-pushed
the
sizebased_rollover
branch
6 times, most recently
from
88b47bf to
d7f4f61
Compare
RanabirChakraborty
force-pushed
the
sizebased_rollover
branch
from
d7f4f61 to
6aa5f7c
Compare
rpelisse
added
the
minor_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/AMW-376
GitHub Issue: #207