Skip to content

Fix password masking JAVA_HOME and undefined variable error #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

guidograzioli
Copy link
Member

@guidograzioli guidograzioli commented Nov 7, 2024

When mask passwords are generated via artemis mask command, the configured JDK is not used.
Refactor the blocks in the mark_passwords.yml taskfile to guard against undefined vars

Fix #196
Fix #197

@guidograzioli guidograzioli added the bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements label Nov 7, 2024
@guidograzioli guidograzioli changed the title 196 undefined existing user Fix password masking command JDK Nov 7, 2024
@guidograzioli guidograzioli merged commit 7d0d1ef into ansible-middleware:main Nov 8, 2024
25 checks passed
@guidograzioli guidograzioli changed the title Fix password masking command JDK Fix password masking JAVA_HOME and undefined variable error Nov 8, 2024
'roles': item.roles }] }}"
no_log: true
when:
- existing_user is not defined or existing_user | length == 0 or hash_password != existing_user[1]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same remark as above

hash_password is not defined if existing_user is not defined.
Something like this would fix it:
            - existing_user is defined and hash_password is defined and  hash_password != existing_user[1]

@AWD09
Copy link

AWD09 commented Nov 14, 2024

sorry, I had no time to review earlier.
I see that it this PR was already merged...

@AWD09
Copy link

AWD09 commented Nov 19, 2024

hi @guidograzioli. Do you know when this will be released?
This is blocking our user and permission management operations

@guidograzioli
Copy link
Member Author

Sorry about that, but we had (actually, we have) a problem with github actions breaking CI arbitrarily. I hope to build the downstream collection and upload to hub on thursday at the very latest

@AWD09
Copy link

AWD09 commented Nov 24, 2024

hi @guidograzioli. Thank you. No problem.
It the porting to the downstream Red Hat amq_broker collection automatic? That is the one we are using

@guidograzioli
Copy link
Member Author

Hello; it is automated but not automatic, we have more CI downstream. However, I've submitted the new release for redhat.amq_broker and should be available shortly

@guidograzioli
Copy link
Member Author

It should be available by now; redhat.amq_broker 2.2.7 will be the last version in tech preview, starting from 2.2.8 it will be GA!

@AWD09
Copy link

AWD09 commented Nov 29, 2024

hi @guidograzioli, is it stuck somewhere or am I too earger? 👉👈
It did not hit redhat.amq_broker yet

@guidograzioli
Copy link
Member Author

hi @guidograzioli, is it stuck somewhere or am I too earger? 👉👈 It did not hit redhat.amq_broker yet

Wait, you cannot see or download 2.2.7 from
https://console.redhat.com/ansible/automation-hub/repo/published/redhat/amq_broker/?

@AWD09
Copy link

AWD09 commented Nov 29, 2024

hi @guidograzioli, is it stuck somewhere or am I too earger? 👉👈 It did not hit redhat.amq_broker yet

Wait, you cannot see or download 2.2.7 from https://console.redhat.com/ansible/automation-hub/repo/published/redhat/amq_broker/?

yes I do and it's there. Thank you.
I used to check on https://catalog.redhat.com/software/collection/redhat/amq_broker where it is not. I'll check on the automation-hub from now on.

@AWD09
Copy link

AWD09 commented Nov 29, 2024

FYI, my play now runs for a normal timespan. Thank you very much we can roll it out in the higher envirnonments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements
Projects
None yet
2 participants