Skip to content

New parameter to configure clustering without HA #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

guidograzioli
Copy link
Member

@guidograzioli guidograzioli commented Sep 23, 2024

Fix configuration for cluster topologies built with only primary servers. The ha-policy template failed to configure properly with activemq_ha_enabled and no backups; with no activemq_ha_enabled active, cluster-connections would not be generated.

New parameters:

Variable Description Default
activemq_cluster_enabled Whether or not to enable clustering (cluster-connections) {{ activemq_ha_enabled }}
activemq_scale_down_enabled Whether or not clustering supports scale-down" false

Fix #176

@guidograzioli guidograzioli added the bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements label Sep 23, 2024
@guidograzioli guidograzioli changed the title Configuration for clustering without HA requires parameter New parameter to configure clustering without HA Sep 23, 2024
@garethahealy
Copy link
Collaborator

I tested against the source but found one issue related to the new activemq_cluster_enabled flag.

The below doesn't have that flag, which means activemq_cluster_nodes is never populated when using activemq_cluster_discovery=provided

@guidograzioli
Copy link
Member Author

I tested against the source but found one issue related to the new activemq_cluster_enabled flag.

The below doesn't have that flag, which means activemq_cluster_nodes is never populated when using activemq_cluster_discovery=provided

OK i think it's complete now, thanks for the help. Can you review?

@garethahealy
Copy link
Collaborator

I've tested the latest. Got 3 clustered brokers, producing 600 messages to broker 1. Messages evenly (200 each) consumed by broker 1, 2 and 3

$ ansible-galaxy collection list | grep "middleware"
middleware_automation.amq     2.2.4
middleware_automation.common  1.2.2

@garethahealy
Copy link
Collaborator

/lgtm

@guidograzioli guidograzioli merged commit 7a2d7db into ansible-middleware:main Sep 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfixes Fixes that resolve issues. SHOULD not be used for minor enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for clustered brokers
2 participants