Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to supress the package logging facts #84

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

dannybrody
Copy link

@dannybrody dannybrody commented Jul 16, 2024

Overall Review of Changes:
There are quite a few tasks that have very verbose logs. It would be nice to have the option to suppress some of these task outputs

Enhancements:
Ability to toggle logging for some very verbose ansible tasks

How has this been tested?:
Running the playbook

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

Signed-off-by: Danny Brody <dbrody@gofundme.com>
Signed-off-by: Danny Brody <dbrody@gofundme.com>
Signed-off-by: Danny Brody <dbrody@gofundme.com>
Signed-off-by: Danny Brody <dbrody@gofundme.com>
@dannybrody dannybrody marked this pull request as ready for review July 16, 2024 21:13
@uk-bolly
Copy link
Member

uk-bolly commented Sep 5, 2024

hi @dannybrody

Thank you for taking the time to raise this PR.
I understand your requirement for this, i am trying to understand why we have default vars set in default/main.yml as well as a default on the task itself?

Many thanks

uk-bolly

@uk-bolly
Copy link
Member

uk-bolly commented Nov 5, 2024

hi @dannybrody

Wondering if you've had time to look at the feedback? Happy to take the PR just rather have defaults set in one place.

Many thanks

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants